fix: polish installer window interactions - #97
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 996b2cbbea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const titlebar = document.querySelector('.app-titlebar'); | ||
| titlebar.addEventListener('pointerdown', event => { | ||
| if (event.button !== 0 || event.target.closest('.window-actions') || !appWindow) return; | ||
| if (event.detail === 2) appWindow.toggleMaximize(); |
There was a problem hiding this comment.
When the user double-clicks the custom title bar in the Tauri/WebView window, this condition never reliably identifies the second press because pointerdown events do not carry the click count in UIEvent.detail outside click/mousedown/mouseup/dblclick events (MDN). The handler therefore falls through to startDragging() instead of toggleMaximize(), so the new double-click maximize behavior remains broken; handle dblclick separately or switch this drag logic to mousedown where detail is populated.
Useful? React with 👍 / 👎.
What changed
Why
The frameless installer window could not reliably be dragged, resizing felt sluggish, and the update-stage/error treatments were visually heavy and inconsistent with the simplified monochrome direction.
Impact
Installer and updater windows are easier to move and resize, while update progress and failure states remain clearer and calmer.
Validation
cargo fmt --checkcargo checkcargo test(7 passed)uv run pre-commit run --all-files